[PATCH] D102601: [NFC][object] Change the input parameter of the method isDebugSection.

EsmeYi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 17 08:01:38 PDT 2021


Esme added a comment.

In D102601#2762856 <https://reviews.llvm.org/D102601#2762856>, @qiucf wrote:

> You added implementation of `XCOFFObjectFile::isDebugSection`, which does not exist before your patch (besides, its implementation is not as 'trivial' as others). Are you sure this is an NFC?

I understand your concern, hmm..., I will move this part to the child revision D102603 <https://reviews.llvm.org/D102603> where this method is really used. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102601/new/

https://reviews.llvm.org/D102601



More information about the llvm-commits mailing list