[PATCH] D102344: [SCEV]: Teach SCEV about llvm.annotation intrinsic

Ettore Tiotto via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 17 06:59:20 PDT 2021


etiotto added a comment.

> I am referring to the summary:
>
>> The llvm.annotation intrinsic returns the first argument passed to it.
>
> As mentioned, this is not a sufficient condition to be just ignored. The summary should also mention that by the LLVM language reference, " are ignored by code generation and optimization."
>
> Suggestion:
>
> As by the LLVM language reference, the `llvm.annotation` intrinsic and no effect on code generation and optimization (https://llvm.org/docs/LangRef.html) and therefore can be safely replaced by its first argument. This patch 'teaches' SCEV the semantics of that builtin function.

Hey Michael, I understand now what you meant. Sure I have updated the description now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102344/new/

https://reviews.llvm.org/D102344



More information about the llvm-commits mailing list