[PATCH] D101103: [InstSimplify] Treat invariant group insts as bitcasts for load operands

[Piotr Padlewski via Phabricator via llvm-commits]

Prazek added inline comments.


================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:5829-5832
+      if (II->getIntrinsicID() != Intrinsic::strip_invariant_group &&
+          II->getIntrinsicID() != Intrinsic::launder_invariant_group)
+        return nullptr;
+      Worklist.push_back(II->getOperand(0));
----------------
nit: personally I would reverse the logic:

  if (II->getIntrinsicID() == Intrinsic::strip_invariant_group &&
      II->getIntrinsicID() == Intrinsic::launder_invariant_group)
    Worklist.push_back(II->getOperand(0));
  else
    return nullptr;

I think it is more canonical and easier to read.
I guess also then you could simplify the assert you have later on to share some code (e.g. isInvariantGroupIntrinsic function)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101103/new/

https://reviews.llvm.org/D101103