[PATCH] D100919: [AArch64] Support customizing stack protector guard

[David Spickett via Phabricator via llvm-commits]

DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.

LGTM with one nit.



================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1919
+    int Offset = Options.StackProtectorGuardOffset;
+    if (Offset >= 0 && Offset <= 32760 && Offset % 8 == 0)
+      // ldr xN, [xN, #offset]
----------------
For all the if/else here I'd include the braces. I know that once the preprocessor is done it'll be a one line if but visually it's confusing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100919/new/

https://reviews.llvm.org/D100919