[PATCH] D95339: [RFC][test] Adapt debug-info lit framework for more general purposes - part 1

Mon May 17 03:09:00 PDT 2021

jhenderson added a comment.

In D95339#2741619 <https://reviews.llvm.org/D95339#2741619>, @jhenderson wrote:

> I'm not convinced we need the behaviour to use the PATH version now. With the CLANG and LLDB environment variables allowing to override which tool is used, and a similar patch for LLD planned for later today, I think we can probably remove the functionality. I've posted https://lists.llvm.org/pipermail/llvm-dev/2021-May/150421.html to discuss this further. Either way, I think the decision that the email chain will hopefully lead to shouldn't hold up proceeding with this patch series. Could I therefore ask people to resume reivewing this series, please?

Quick update on this: D101982 <https://reviews.llvm.org/D101982> fixes the environment variable for LLDB to be 'LLDB' not 'CLANG', so that it is now possible to specify that executable as requested by @aprantl. I have dropped the other new environment variables, as there has been no specific request for them, but can easily readd them, should the need arise. I will upload a new review, likely later today, to try disabling the wider PATH usage for these tools, but it is a somewhat independent item now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95339/new/

https://reviews.llvm.org/D95339