[PATCH] D102477: X86: support Swift Async context

Tim Northover via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 17 02:49:35 PDT 2021


t.p.northover closed this revision.
t.p.northover added a comment.

Thanks, committed as ea0eec69 <https://reviews.llvm.org/rGea0eec69f16e0f1b00fec413986e4e44f6f627fa>



================
Comment at: llvm/lib/Target/X86/X86MachineFunctionInfo.h:116
+
+  Optional<int> SwiftAsyncContextFrameIdx;
+
----------------
jroelofs wrote:
> I found the naming of these two a bit confusing... bit of a semantic uncanny valley, since they're almost but not quite referring to the same thing. I don't have a better suggestion though :(
Yes, it's a bit messy.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102477/new/

https://reviews.llvm.org/D102477



More information about the llvm-commits mailing list