[PATCH] D101945: [LV] Add -scalable-vectorization=<option> flag.

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm accepted this revision.
paulwalker-arm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/Transforms/Vectorize/LoopVectorizationLegality.h:149-150
+  bool isScalableVectorizationExplicitlyEnabled() const {
+    return (ScalableForceKind)Scalable.Value == SK_PreferFixedWidth ||
+           (ScalableForceKind)Scalable.Value == SK_PreferScalable;
+  }
----------------
Now that you're not comparing against `SK_Unspecified` you probably don't need the `(ScalableForceKind)` casting.  If you prefer to keep the casting then I suggest `isScalableVectorizationDisabled()` should also have it.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp:60
+        clEnumValN(LoopVectorizeHints::SK_FixedWidthOnly, "off",
+                   "Scalable vectorisation is disabled."),
+        clEnumValN(LoopVectorizeHints::SK_PreferFixedWidth, "on",
----------------
Sorry my bad :) you probably want `s/vectorisation/vectorization/`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101945/new/

https://reviews.llvm.org/D101945