[PATCH] D102466: [RISCV] Support RVP vectors in the calling convention

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck added a comment.

As mentioned, I think this patch is missing test cases for vector types smaller or larger than XLEN.



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:6803
+      LocInfo = CCValAssign::BCvt;
+    } else {
+      // Fixed-length vectors are located in the corresponding scalable-vector
----------------
Can this `else` ever fall through with P? What if you passed `<4 x i64>`? Should `P` ensure that vectors are correctly broken down into XLen-sized part vectors?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102466/new/

https://reviews.llvm.org/D102466