[PATCH] D102542: [GlobalISel] Simplify G_ICMP to true/false when the result is known

[Jay Foad via Phabricator via llvm-commits]

foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:3974
+      *KnownVal
+          ? getICmpTrueVal(getTargetLowering(),
+                           /*IsVector = */
----------------
Not really related, but I don't understand why getICmpTrueVal takes an IsFP argument.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102542/new/

https://reviews.llvm.org/D102542