[PATCH] D102234: [SimpleLoopBoundSplit] Split Bound of Loop which has conditional branch with IV

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 17 01:25:03 PDT 2021


SjoerdMeijer added a comment.

Some drive by comments:

- Bike shedding names:  `SimpleLoopBoundSplit`. How about just `LoopBoundSplit`? I understand the current implementation has restrictions/limitations, but personally I think it looks a bit silly all these SimpleLoopXYZ passes/names.
- You probably want to add this to the optimisation pipeline somewhere, off by default for now,
- I guess we want to skip with this transformation with OptForSize,
- I haven't looked into much details, but I guess you look only at one if-statement and thus we don't support things like `if ( i > c1 && i < c2)`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102234/new/

https://reviews.llvm.org/D102234



More information about the llvm-commits mailing list