[PATCH] D102355: Add support for DWARF embedded source to llvm-symbolizer

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

I've got no specific comments on the source code, just one small nit in the test. I'll leave @dblaikie to continue the rest of the review.



================
Comment at: llvm/test/tools/llvm-symbolizer/source.ll:8
+;; Check the source context plain printout.
+; RUN: llvm-symbolizer --print-source-context-lines=3 "CODE %t.o 0" | \
+; RUN:   FileCheck %s --strict-whitespace --match-full-lines --implicit-check-not={{.}}
----------------
It would probably be a good idea to run the exact same check for GNU output (or llvm-addr2line), just to cover our bases. That way, if the behaviour ever diverges in the future, there's a clear test to update.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102355/new/

https://reviews.llvm.org/D102355