[PATCH] D102432: [AMDGPU] Add support for architected flat scratch

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:496-504
+  if ((MFI->hasFlatScratchInit() || ScratchRsrcReg) &&
+      !ST.flatScratchIsArchitected()) {
     MRI.addLiveIn(PreloadedScratchWaveOffsetReg);
     MBB.addLiveIn(PreloadedScratchWaveOffsetReg);
   }
 
   if (MFI->hasFlatScratchInit()) {
----------------
t-tye wrote:
> Does the architected flat scratch register pair also need to be made live in when scratch is enabled and architected flat scratch is supported?
No, it does not. It is unallocatable anyway.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102432/new/

https://reviews.llvm.org/D102432