[PATCH] D102371: [AMDGPU] Refactor shouldExpandAtomicRMWInIR(). NFC.

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 12 14:25:46 PDT 2021


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12113
 
-    if (!Ty->isFloatTy() && (!Subtarget->hasGFX90AInsts() || !Ty->isDoubleTy()))
+    if (!Ty->isFloatTy() && !(Subtarget->hasGFX90AInsts() && Ty->isDoubleTy()))
       return AtomicExpansionKind::CmpXChg;
----------------
arsenm wrote:
> I think the previous demorganed version is easier
Is it? I had some troubles reading it. I do not have a strong opinion though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102371/new/

https://reviews.llvm.org/D102371



More information about the llvm-commits mailing list