[PATCH] D102371: [AMDGPU] Refactor shouldExpandAtomicRMWInIR(). NFC.
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 12 14:22:52 PDT 2021
rampitec created this revision.
rampitec added reviewers: t-tye, arsenm.
Herald added subscribers: kerbowa, jfb, hiraditya, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl.
rampitec requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.
This is logic simplification for better readability.
https://reviews.llvm.org/D102371
Files:
llvm/lib/Target/AMDGPU/SIISelLowering.cpp
Index: llvm/lib/Target/AMDGPU/SIISelLowering.cpp
===================================================================
--- llvm/lib/Target/AMDGPU/SIISelLowering.cpp
+++ llvm/lib/Target/AMDGPU/SIISelLowering.cpp
@@ -12110,10 +12110,9 @@
if (Ty->isHalfTy())
return AtomicExpansionKind::None;
- if (!Ty->isFloatTy() && (!Subtarget->hasGFX90AInsts() || !Ty->isDoubleTy()))
+ if (!Ty->isFloatTy() && !(Subtarget->hasGFX90AInsts() && Ty->isDoubleTy()))
return AtomicExpansionKind::CmpXChg;
- // TODO: Do have these for flat. Older targets also had them for buffers.
unsigned AS = RMW->getPointerAddressSpace();
if ((AS == AMDGPUAS::GLOBAL_ADDRESS || AS == AMDGPUAS::FLAT_ADDRESS) &&
@@ -12129,20 +12128,22 @@
return AtomicExpansionKind::CmpXChg;
if (Subtarget->hasGFX90AInsts()) {
+ if (Ty->isFloatTy() && AS == AMDGPUAS::FLAT_ADDRESS)
+ return AtomicExpansionKind::CmpXChg;
+
auto SSID = RMW->getSyncScopeID();
if (SSID == SyncScope::System ||
SSID == RMW->getContext().getOrInsertSyncScopeID("one-as"))
return AtomicExpansionKind::CmpXChg;
- return (Ty->isFloatTy() && AS == AMDGPUAS::FLAT_ADDRESS) ?
- AtomicExpansionKind::CmpXChg : AtomicExpansionKind::None;
+ return AtomicExpansionKind::None;
}
- if (!Subtarget->hasGFX90AInsts() && AS != AMDGPUAS::GLOBAL_ADDRESS)
+ if (AS == AMDGPUAS::FLAT_ADDRESS)
return AtomicExpansionKind::CmpXChg;
- return RMW->use_empty() ? AtomicExpansionKind::None :
- AtomicExpansionKind::CmpXChg;
+ return RMW->use_empty() ? AtomicExpansionKind::None
+ : AtomicExpansionKind::CmpXChg;
}
// DS FP atomics do repect the denormal mode, but the rounding mode is fixed
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102371.344960.patch
Type: text/x-patch
Size: 1848 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210512/84e7e167/attachment-0001.bin>
More information about the llvm-commits
mailing list