[PATCH] D102347: [AMDGPU] Only allow global fp atomics with unsafe option

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12147-12153
     // DS FP atomics do repect the denormal mode, but the rounding mode is fixed
     // to round-to-nearest-even.
     // The only exception is DS_ADD_F64 which never flushes regardless of mode.
     if (AS == AMDGPUAS::LOCAL_ADDRESS && Subtarget->hasLDSFPAtomics()) {
       return (Ty->isDoubleTy() && !fpModeMatchesGlobalFPAtomicMode(RMW)) ?
         AtomicExpansionKind::CmpXChg : AtomicExpansionKind::None;
     }
----------------
t-tye wrote:
> Should the amdgpu-unsafe-fp-atomics also ally here too? If not should the attribute be named to reflect it only allies to global fp atomics?
This is LDS, so does not have the same problem with mtypes. We can skip denorms check, but that would be a separate patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102347/new/

https://reviews.llvm.org/D102347