[PATCH] D101247: [Debug-Info] strict dwarf for DW_OP_stack_value

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 12 01:06:53 PDT 2021


jhenderson added a comment.

In D101247#2752337 <https://reviews.llvm.org/D101247#2752337>, @dblaikie wrote:

> @aprantl @probinson @JDevlieghere @jhenderson - you folks have any opinions on this? I think it might be worth pushing expression emission through some common interface - the hand-crafted expressions we emit in a few places could probably be refactored to some common structure (either a DwarfExpression, or some other thing that could adapt from both DwarfExpression and these hand crafted expressions)

I'm afraid the DwarfExpression and related code is not something I'm really familiar with, so can't provide a useful opinion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101247/new/

https://reviews.llvm.org/D101247



More information about the llvm-commits mailing list