[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

Mon May 10 00:38:41 PDT 2021

shchenz added a comment.

In D100630#2745272 <https://reviews.llvm.org/D100630#2745272>, @dblaikie wrote:

> Mixed feelings - is this the only place where we're changing behavior for strict-DWARF in the frontend/clang? (maybe it'd be better to do it all in the same place, down in the backend when the IR is mapped to actual DWARF)

Update the patch to do the check down in the backend. Seems we already have one centralized interface for TAGs generation.

> @aprantl @probinson - you two have any thoughts on this layering aspect?
>
> I think for CodeView we make some different choices up in the frontend (& completely different implementations in the backend), so it's not totally unreasonable, but curious how folks feel.

Welcome your comments! @aprantl @probinson

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100630/new/

https://reviews.llvm.org/D100630