[PATCH] D102582: [PoC][RISCV] Report an error when target-abi option is empty but target-abi module flag is not.
Zakk Chen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun May 16 19:27:56 PDT 2021
khchen updated this revision to Diff 345738.
khchen marked 2 inline comments as done.
khchen added a comment.
1. address @jrtc27' comment
2. change report_fatal_error as errs() because report_fatal_error will ask users to submit a bug report, it does not make sense.
3. combine two error message as one.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102582/new/
https://reviews.llvm.org/D102582
Files:
llvm/lib/Target/RISCV/RISCVTargetMachine.cpp
llvm/test/CodeGen/RISCV/module-target-abi.ll
llvm/test/CodeGen/RISCV/module-target-abi2.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102582.345738.patch
Type: text/x-patch
Size: 5105 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210517/b5310189/attachment.bin>
More information about the llvm-commits
mailing list