[PATCH] D102260: Update MSVC version number in preprocessor check

[Neal via Phabricator via llvm-commits]

nealsid added a comment.

Sorry, this got a little complicated.  On my previous install I had VS 2019 16.5, which ran into the compile error.  When I reinstalled, 16.0, 16.6, and 16.9 worked, but 16.4/16.5 did not.  Sounds like a super tiny regression for only 2 minor updates.  As far as the actual issue, I could not fully understand it, but it seems to have something to do with applying parameter pack arguments while also using default values for std::map template parameters.

For the actual patch, we could:

- Leave the version number check at 1926 and update the comment to mention 16.4/16.5 not building is known.
- Update the preprocessor check to version >= 1920 (which is VS2019 16.0) and != 1924/1925 (16.4/16.5).  I'm guessing most people are upgraded past 16.4/16.5 though, so a preprocessor check for those versions may not be used all that much in practice...and would probably hang around the code base forever ;).

Thanks,

Neal


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102260/new/

https://reviews.llvm.org/D102260