[PATCH] D102401: [AMDGPU] Allocate LDS globals in sorted order of their alignment and size.

[Mahesha S via Phabricator via llvm-commits]

hsmhsm added a comment.

In D102401#2761858 <https://reviews.llvm.org/D102401#2761858>, @hsmhsm wrote:

> In D102401#2760317 <https://reviews.llvm.org/D102401#2760317>, @rampitec wrote:
>
>> In D102401#2759276 <https://reviews.llvm.org/D102401#2759276>, @hsmhsm wrote:
>>
>>> In D102401#2757441 <https://reviews.llvm.org/D102401#2757441>, @rampitec wrote:
>>>
>>>> We probably need a test which only runs this lowering and showing a resulting transformed IR. Test the alignment, sorting and situation with multiple kernels using intersecting LDS variable sets.
>>>
>>> Added test - lds-allocation.ll.  However, note that we actually do not update the alignment of LDS globals within the module,  during allocation, we only just compute the required natural alignment for proper allocation.
>>
>> I mean an IR test where we can see what lowering has done, not just total allocation amount.
>
> Probably then, we need to dump the MIR result by passing the option - "--print-after-isel", and then we need to test for the memory address. But, I see this address is still based on alignment info avaialble in the IR. So, I think, we need to first explicitly update the alignment of LDS globals in a seperate OPT pass just before ISEL pass?

I have updated the lit test to check the output of the "instruction selection" pass.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102401/new/

https://reviews.llvm.org/D102401