[PATCH] D102580: [Demangle][Rust] Parse pointer types

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 16 10:28:23 PDT 2021


dblaikie added inline comments.


================
Comment at: llvm/test/Demangle/rust.test:181-182
 
+CHECK: types::<&u8>
+       _RIC5typesRhE
+
----------------
The changes in which features are used to test (for instance in the previous patch/tests - for "T" in this similar context, generic args ("p"/"_") were used, but this one uses u8 - it'd be good to be consistent unless there's a particular reason for the variation (in which case maybe a comment explaining what's significant, or not, about these cases, would be useful).

(similarly back to the 'A' and 'S' productions in the types set, further up)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102580/new/

https://reviews.llvm.org/D102580



More information about the llvm-commits mailing list