[PATCH] D102579: [Demangle][Rust] Parse tuples

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 16 10:26:11 PDT 2021


dblaikie added inline comments.


================
Comment at: llvm/lib/Demangle/RustDemangle.cpp:450-451
+    }
+    if (I == 1)
+      print(",");
+    print(")");
----------------
Looks a bit awkward to print a comma after a single argument (`(_,)`) - is that necessary? (does it disambiguate this with some other case that has only a list of 1 between parentheses?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102579/new/

https://reviews.llvm.org/D102579



More information about the llvm-commits mailing list