[PATCH] D102573: [Demangle][Rust] Parse array type

Sun May 16 10:21:38 PDT 2021

dblaikie accepted this revision.
dblaikie added inline comments.
This revision is now accepted and ready to land.

================
Comment at: llvm/test/Demangle/rust.test:160-165
+CHECK: types::<[_; _]>
+       _RIC5typesAppE
+
+CHECK: types::<[u8; 0]>
+       _RIC5typesAhj0_E
+
----------------
Is it worth having two tests here? The parser seems fairly orthogonally designed and generic args ('p') don't seem more likely to be buggy/weird than any other argument type, such as the u8/0 in the second case? Might be inclined towards only having the second test, unless there's some interesting interaction with the generic args I'm missing.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102573/new/

https://reviews.llvm.org/D102573