[PATCH] D98305: [JITLink] Introduce generic x86-64 support by refactoring MachO/x86-64.

[Lang Hames via Phabricator via llvm-commits]

lhames added a comment.

In D98305#2761733 <https://reviews.llvm.org/D98305#2761733>, @NathanielMcVicar wrote:

> Hi Lang,
>
> Unfortunately, I don't think there's currently a working bot running the LLVM tests on Windows. I can see the failure locally on my machine and in our internal CI, top of tree with the following configuration (host triple is x86_64-pc-windows-msvc):
>
>   -G Ninja -DCMAKE_BUILD_TYPE=Debug -DLLVM_ENABLE_PROJECTS=clang;lld;lldb;mlir -DLLVM_TARGETS_TO_BUILD=host -DLLDB_INCLUDE_TESTS=OFF -DLLVM_ENABLE_ASSERTIONS=ON

Hi Nathaniel,

I don't have access to a Windows machine to test on, but I think Dave Blaikie has spotted the bug -- A think-o in the existing comparator meant that it did not provide a strict weak ordering. Could you let you know if d1a7630369bc <https://reviews.llvm.org/rGd1a7630369bc489ca85e7fd0e05119a6d6f09039> fixes the issue for you?

Thanks for reporting this, and thanks Dave for spotting the issue.

- Lang.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98305/new/

https://reviews.llvm.org/D98305