[PATCH] D102582: [PoC][RISCV] Report an error when target-abi option is empty but target-abi module flag is not.
Jessica Clarke via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun May 16 09:51:36 PDT 2021
jrtc27 added inline comments.
================
Comment at: llvm/lib/Target/RISCV/RISCVTargetMachine.cpp:95-115
+ // The taget-abi option should equal to target-abi module flag because
+ // the different ABI has its corresponding datalayout and IR alignment
+ // information. In other words, the IR parser need to have datalayout
+ // information before it gets the ABI info from module. It does not make
+ // sense to update the module's datalayout and alignment information after
+ // IR parsing, so we just report an error and require user to give a correct
+ // -target-abi option.
----------------
Please spell-check this and correctly capitalise things like DataLayout.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102582/new/
https://reviews.llvm.org/D102582
More information about the llvm-commits
mailing list