[compiler-rt] 7085cd2 - [Compiler-rt] Downgrade fatal error about unsupported test configuration

Dan Liew via llvm-commits llvm-commits at lists.llvm.org
Sat May 15 10:55:06 PDT 2021


Author: Dan Liew
Date: 2021-05-15T10:52:10-07:00
New Revision: 7085cd2f2945b1e73e1c66f78080c48cba9112e8

URL: https://github.com/llvm/llvm-project/commit/7085cd2f2945b1e73e1c66f78080c48cba9112e8
DIFF: https://github.com/llvm/llvm-project/commit/7085cd2f2945b1e73e1c66f78080c48cba9112e8.diff

LOG: [Compiler-rt] Downgrade fatal error about unsupported test configuration
to a warning.

https://reviews.llvm.org/D101681 introduced a check to make sure the
compiler and compiler-rt were using the same library path when
`COMPILER_RT_TEST_STANDALONE_BUILD_LIBS=ON`, i.e. the developer's
intention is to test the just built libs rather that shipped with the
compiler used for testing.

It seems this broken some bots that are likely misconfigured.

So to unbreak them, for now let's make this a warning so the bot
owners can investigate without breaking their builds.

Added: 
    

Modified: 
    compiler-rt/test/lit.common.cfg.py

Removed: 
    


################################################################################
diff  --git a/compiler-rt/test/lit.common.cfg.py b/compiler-rt/test/lit.common.cfg.py
index 651ff5e9e928..294703fb7fb8 100644
--- a/compiler-rt/test/lit.common.cfg.py
+++ b/compiler-rt/test/lit.common.cfg.py
@@ -133,7 +133,9 @@ def get_path_from_clang(args, allow_failure):
       # Use just built runtime libraries, i.e. the the libraries this built just built.
       if not config.test_suite_supports_overriding_runtime_lib_path:
         # Test suite doesn't support this configuration.
-        lit_config.fatal(
+        # TODO(dliew): This should be an error but it seems several bots are
+        # testing incorrectly and having this as an error breaks them.
+        lit_config.warning(
             'COMPILER_RT_TEST_STANDALONE_BUILD_LIBS=ON, but this test suite '
             'does not support testing the just-built runtime libraries '
             'when the test compiler is configured to use 
diff erent runtime '


        


More information about the llvm-commits mailing list