[PATCH] D102550: [ValueTracking] Mark GEP operand as nonnull if the result was loaded or stored

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 15 04:10:35 PDT 2021


lebedev.ri added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:2137
+          V == GEP->getPointerOperand() &&
+          isGEPKnownNonNull(GEP, Depth + 1, Q)) {
+        unsigned GEPUsesExplored = 0;
----------------
Doesn't this cause endless recursion back into `isKnownNonNullFromDominatingCondition()`
for the very same value we've started with?
(and we happen to not deadloop just because of depth cutoff)



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102550/new/

https://reviews.llvm.org/D102550



More information about the llvm-commits mailing list