[PATCH] D102486: Use a non-recursive mutex in GsymCreator.

Sat May 15 02:44:32 PDT 2021

simon.giesecke added a comment.

In D102486#2760834 <https://reviews.llvm.org/D102486#2760834>, @clayborg wrote:

> In D102486#2760645 <https://reviews.llvm.org/D102486#2760645>, @grandinj wrote:
>
>> In D102486#2759417 <https://reviews.llvm.org/D102486#2759417>, @simon.giesecke wrote:
>>
>>> GSYM conversion still spends a significant time for locking in `GsymCreator::insertString` even with only 8 threads, so lock contention seems to be generally an issue
>>
>> Could perhaps start by moving the CachedHashStringRef construction outside the lock?
>
> The "Copy" argument is usually set to "false" so it won't end up copying the string. We only have to back the string up if the DWARF information had no mangled name for an entry and we and up calculating a fully qualified name by traversing the DWARF. This is rare though.

The "Copy" case might be rare, but the hash needs to be calculated regardless of whether "Copy" is true.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102486/new/

https://reviews.llvm.org/D102486