[PATCH] D102524: [Demangle][Rust] Parse char constants

Tomasz Miąsko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 15 01:31:32 PDT 2021


tmiasko marked an inline comment as done.
tmiasko added inline comments.


================
Comment at: llvm/lib/Demangle/RustDemangle.cpp:469-472
+  uint64_t CodePoint = parseHexNumber(HexDigits);
+  if (Error || HexDigits.size() > 8) {
+    Error = true;
+    return;
----------------
dblaikie wrote:
> Is this error path tested?
I added a test case covering this, and used slightly tighter size bound on the number of digits.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102524/new/

https://reviews.llvm.org/D102524



More information about the llvm-commits mailing list