[PATCH] D102546: [lld][WebAssembly] Refactor input chunk class hierarchy. NFC

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 14 21:51:58 PDT 2021


sbc100 created this revision.
Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, dschuff.
sbc100 requested review of this revision.
Herald added subscribers: llvm-commits, aheejin.
Herald added a project: LLVM.

The main motivation for this refactor is to remove the subclass
relationship between the InputSegment and MergeInputSegment and
SyntenticMergedInputSegment so that we can use the merging classes for
debug sections which are not data segments.

In the process of refactoring I also remove all the virtual functions
from the class hierarchy and tried to reusing techniques used in the ELF
linker (see `lld/ELF/InputSections.h`).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D102546

Files:
  lld/wasm/Driver.cpp
  lld/wasm/InputChunks.cpp
  lld/wasm/InputChunks.h
  lld/wasm/InputFiles.cpp
  lld/wasm/InputFiles.h
  lld/wasm/OutputSections.cpp
  lld/wasm/OutputSegment.cpp
  lld/wasm/OutputSegment.h
  lld/wasm/SymbolTable.cpp
  lld/wasm/SymbolTable.h
  lld/wasm/Symbols.cpp
  lld/wasm/Symbols.h
  lld/wasm/SyntheticSections.cpp
  lld/wasm/Writer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102546.345606.patch
Type: text/x-patch
Size: 33319 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210515/5f026204/attachment.bin>


More information about the llvm-commits mailing list