[PATCH] D102524: [Demangle][Rust] Parse char constants

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks good - might need a test case for the error path if it's not already exercised by one of the other invalid tests (in which case does that invalid test changing to test this error path stop catching some error path that needs a new test instead?)



================
Comment at: llvm/lib/Demangle/RustDemangle.cpp:469-472
+  uint64_t CodePoint = parseHexNumber(HexDigits);
+  if (Error || HexDigits.size() > 8) {
+    Error = true;
+    return;
----------------
Is this error path tested?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102524/new/

https://reviews.llvm.org/D102524