[PATCH] D102533: [NFC][OpaquePtr] Avoid using PointerType::getElementType() in VectorUtils.cpp

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/lib/Analysis/VectorUtils.cpp:967
 
-      Value *Ptr = getLoadStorePointerOperand(&I);
       // We don't check wrapping here because we don't know yet if Ptr will be
----------------
nikic wrote:
> Depending on how common the pattern is, it might make sense to add `getLoadStoreType` to complement `getLoadStorePointerOperand` (and `getLoadStoreAlignment` and `getLoadStoreAddressSpace`).
Yeah, +1. There's something like 40 calls to this function, so probably worth having an opaque pointer equivalent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102533/new/

https://reviews.llvm.org/D102533