[PATCH] D102523: [docs] Explain address spaces a bit more in opaque pointers doc

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added a comment.

The new paragraph or something similar LGTM, although probably @theraven should be the one to sign off given the post-commit feedback.

In D102523#2760520 <https://reviews.llvm.org/D102523#2760520>, @tschuett wrote:

> This text explicitly does not talk about address spaces. For typed and opaque pointers, they still play the same role. For more information, see
> `DataLayout <LangRef.html#langref-datalayout>`_.

I'm not sure; I feel like @aeubanks's current text might be a little more useful, if the purpose is to head off the sorts of questions brought up in https://reviews.llvm.org/D102292. Pointers have two axes of variability/kinds and we're taking one away; I don't think everyone has clarity on what each one was for in the first place. IMO, this should serve as a "if you're worried about lowering, that's not changing, don't worry" kind of disclaimer, carving a distinction between the two axes. With your suggested more succinct text, the reader must already fully understand address spaces vs. pointer types to get that insight.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102523/new/

https://reviews.llvm.org/D102523