[PATCH] D102509: [lld][X86] Restore gotEntrySize.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 14 15:28:09 PDT 2021


MaskRay added a comment.

Is x86-x32-plt.s NFC for now and you'll create another patch to fix x32?



================
Comment at: lld/test/ELF/x86-x32-plt.s:7
+# RUN: ld.lld %t.o %t2.so -o %t
+# RUN: ld.lld -shared %t.o %t2.so -o %t.so
+# RUN: llvm-readelf -S -r %t | FileCheck %s --check-prefix=CHECK1
----------------
You can drop %t.so testing.

I added more to x86-64-plt.s because there needs a test to check additional target agnostic properties.

x86-x32-plt.s doesn't need to replicate the testing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102509/new/

https://reviews.llvm.org/D102509



More information about the llvm-commits mailing list