[PATCH] D102296: [ELF] getRelocatedSection: allow allocatable section in non-relocatable file

Maksim Panchenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 14 14:23:00 PDT 2021


maksfb added inline comments.


================
Comment at: llvm/include/llvm/Object/ELFObjectFile.h:979-981
+  if (EF.getHeader().e_type != ELF::ET_REL &&
+      !((*SecOrErr)->sh_flags & ELF::SHF_ALLOC))
+    return section_end();
----------------
These extra checks are unnecessary on LLVM side. Let's get rid of them and update the diff description.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102296/new/

https://reviews.llvm.org/D102296



More information about the llvm-commits mailing list