[PATCH] D102419: [MinGW] Always enable -mbig-obj for LLVM build unless using Clang

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 14 12:38:55 PDT 2021


mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.

In D102419#2759985 <https://reviews.llvm.org/D102419#2759985>, @mati865 wrote:

> I don't know when they exactly appear but look at my building log: https://reviews.llvm.org/P8263
> The build was done with 16 threads so it's hard to tell which objects made it appear.

When building with ninja, the output is buffered so the warnings appear directly after the specific build target that cause them. I was able to reproduce it with my toolchains also, when removing the `-Qunused-arguments` that I have in the clang wrapper - the warning is printed when linking.

The change LGTM, I'll amend the commit message before pushing, to something like this:

> Clang does it automagically, so it's not needed there, and the option causes warnings about being unused when linking.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102419/new/

https://reviews.llvm.org/D102419



More information about the llvm-commits mailing list