[PATCH] D102514: [LLD][MinGW] Add --fatal-warnings and --no-fatal-warnings flags

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

> Couldn't find the pattern for ordering flags in Driver.cpp so put it in a random position.

Yeah there's probably no very clear pattern, so far it's mostly grouped according to options that have similar code for handling them.



================
Comment at: lld/MinGW/Options.td:49
+defm fatal_warnings: B<"fatal-warnings",
+    "Treat warnings as erros",
+    "Do not treat warnings as errors (default)">;
----------------
Typo, `erros`.


================
Comment at: lld/test/MinGW/driver.test:298
+
+RUN: ld.lld -### -m i386pep foo.o | FileCheck -check-prefix FATAL_WARNINGS %s
+RUN: ld.lld -### -m i386pep foo.o -fatal-warnings | FileCheck -check-prefix FATAL_WARNINGS %s
----------------
This line doesn't seem to match the default indicated both in Options.td and the code (and the CI also seems to conclude that this fails).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102514/new/

https://reviews.llvm.org/D102514