[PATCH] D102136: [NewPM] Add C bindings for new pass manager

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 14 11:56:16 PDT 2021


aeubanks accepted this revision.
aeubanks added a comment.
This revision is now accepted and ready to land.

looks good aside from one super duper nit
do you have commit permission?



================
Comment at: llvm/include/llvm-c/Transforms/PassBuilder.h:48-50
+LLVMErrorRef LLVMRunPasses(LLVMTargetMachineRef TM, LLVMModuleRef M,
+                           LLVMPassBuilderOptionsRef Options,
+                           const char *Passes);
----------------
super duper nit, I'd move the module first, passes string second, TM third, and options fourth, so that the more important things are the earlier parameters


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102136/new/

https://reviews.llvm.org/D102136



More information about the llvm-commits mailing list