[PATCH] D102429: [CSSPGO] Update pseudo probe distribution factor based on inline context.

[Hongtao Yu via Phabricator via llvm-commits]

hoy added a comment.

In D102429#2760347 <https://reviews.llvm.org/D102429#2760347>, @wlei wrote:

> Try to understand this:
>
> So we merge the samples from the same function but different context, does this cause the issue?

Exactly.

>> Such probes should not share samples and their factors should be fixed up separately.
>
> So with that, when code duplication happens, we need to fix probe factor, so here it will do it separately by grouping the probe by different inline context. then each group work for one context inlining. is my understanding correct?

That's right. Probe in a function profile can have multiple copies due to code duplication. We just want to share the corresponding samples among these duplications, but not among all probes with same id but from different function profiles.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102429/new/

https://reviews.llvm.org/D102429