[PATCH] D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records

[Yusra Syeda via Phabricator via llvm-commits]

yusra.syeda marked 7 inline comments as done.
yusra.syeda added inline comments.


================
Comment at: llvm/include/llvm/Object/GOFF.h:35
+public:
+  Record() : Bytes(GOFF::RecordLength, (char)0x00) {
+    set<uint8_t>(0, GOFF::PTVPrefix);
----------------
jhenderson wrote:
> jhenderson wrote:
> > Any particular reason you've used `(char)0x00` rather than simply `\0`?
> Ping this comment?
Using `\0` causes a build failure.


================
Comment at: llvm/lib/Object/GOFFObjectFile.cpp:190
+  SmallString<256> SymbolName;
+  if (auto Err = ESDRecord::getData(getSymbolEsdRecord(Symb), SymbolName))
+    return std::move(Err);
----------------
jhenderson wrote:
> Have you built this code? This error looks like it would break the build...
This is fixed with the new changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98437/new/

https://reviews.llvm.org/D98437