[PATCH] D102429: [CSSPGO] Update pseudo probe distribution factor based on inline context.

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 14 10:37:07 PDT 2021


hoy added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/SampleProfileProbe.cpp:121
     if (Optional<PseudoProbe> Probe = extractProbe(I))
-      ProbeFactors[Probe->Id] += Probe->Factor;
+      ProbeFactors[Probe.getValue()] += Probe->Factor;
   }
----------------
wenlei wrote:
> is `getValue` a new member of `PseudoProbe` struct? didn't find the definition. 
`getValue` is a method of `Optional`. It returns the underlying PseudoProbe object.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102429/new/

https://reviews.llvm.org/D102429



More information about the llvm-commits mailing list