[PATCH] D102429: [CSSPGO] Update pseudo probe distribution factor based on inline context.

Wei Mi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 14 09:30:26 PDT 2021


wmi added inline comments.


================
Comment at: llvm/include/llvm/IR/PseudoProbe.h:85
   float Factor;
+  DILocation *InlineAt;
 
----------------
InlineAt saves the pointer of DILocation which may become dangling easily, so the current intention is to use it in a single pass PseudoProbeUpdatePass. If it is only used in a single pass, can we use a separate map to save the information instead of adding a field in PseudoProbe, so the fields in struct PseudoProbe all contain persistent information.   


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102429/new/

https://reviews.llvm.org/D102429



More information about the llvm-commits mailing list