[PATCH] D101980: [RFC] [Coroutines] Put the contents of byval argument to the frame

Xun Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 14 08:37:47 PDT 2021


lxfind added a comment.

In D101980#2758843 <https://reviews.llvm.org/D101980#2758843>, @ChuanqiXu wrote:

> In D101980#2758780 <https://reviews.llvm.org/D101980#2758780>, @lxfind wrote:
>
>> Something like this: D102465 <https://reviews.llvm.org/D102465>. Let me know what you think.
>
> Oh it is tricky. Since we add a new intrinsic use for the alloca and the intrinsic can't be analyzed by other passes. So the alloca we want wouldn't be optimized. The overall ideas looks good. For the details, I would like to emit the intrinsic for the arguments who are passed by value only. I think we could dive into it further.

Yeah and that's much easier to figure out in the front-end than in the IR.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101980/new/

https://reviews.llvm.org/D101980



More information about the llvm-commits mailing list