[PATCH] D102084: Fix lld macho standalone build by including llvm/Config/llvm-config.h instead of llvm/Config/config.h

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.
Herald added a reviewer: gkm.

Sorry about the delay here.



================
Comment at: llvm/cmake/modules/LLVMConfig.cmake.in:114
 
+set(HAVE_LIBXAR "@HAVE_LIBXAR")
+
----------------
While patching this in locally to land, I noticed that this doesn't have the trailing `@` that all other lines in this file have. Are you sure this does the right thing as-is?

Also, everything in this file and almost everything in llvm-config.h starts with `LLVM_` which makes sense if the purpose of this file is to include it in external codebases. Maybe we should add an `LLVM_` prefix to this and the other symbol in this change? (But not sure about this part.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102084/new/

https://reviews.llvm.org/D102084