[PATCH] D99055: [llvm-objcopy] Refactor CopyConfig structure.

[Alexey Lapshin via Phabricator via llvm-commits]

avl added a comment.

> Do you actually need WasmConfig and COFFConfig? If we can avoid adding them, that would be nice.

Other than specific options set we also need to do following calls for validation:

  virtual Expected<const COFFConfig &> getCOFFConfig() const = 0;
  virtual Expected<const WasmConfig &> getWasmConfig() const = 0;

I think it is good to have these calls to be done in the same way as other getSpecificConfig() methods. Thus, It looks like we still need to have WasmConfig and COFFConfig structures.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99055/new/

https://reviews.llvm.org/D99055