[PATCH] D102424: [flang] Clean up file formats

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added a comment.

@PeteSteinfeld , many thanks for this patch!

LGTM, though I think it is worth waiting to see how https://github.com/google/llvm-premerge-checks/issues/303 is resolved. Also, perhaps this should be formatted with clang-format-12 instead of ToT? Given that LLVM 12 has just been released, I suspect that the the results will be (almost) identical. I'm suggesting this as we won't be getting anything more recent than clang-format-12 in LLVM's pre-merge checks any time soon (not until LLVM 13 is released).



================
Comment at: flang/lib/Optimizer/CodeGen/PreCGRewrite.cpp:66
+/// %3 = fir.embox %0 (%1) [%2] : (!fir.ref<!fir.array<?xi32>>,
+/// !fir.shapeshift<1>, !fir.slice<1>) -> !fir.box<!fir.array<?xi32>>
 /// ```
----------------
PeteSteinfeld wrote:
> schweitz wrote:
> > Does this change the doxygen produced?
> I have no idea.  How do I check?
AFAIK, it does not. Doxygen would require `\n` to force a newline here (see the [[ https://www.doxygen.nl/manual/commands.html#cmdn | docs ]]).

Just to be on the safe side, I checked what happens elsewhere in LLVM:
* comments in source code spanning multiple lines: [[ https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clangd/GlobalCompilationDatabase.h#L165-L167 | link ]]
* generated Doxygen: [[ https://clang.llvm.org/extra/doxygen/namespaceclang_1_1clangd.html#a93d17488d5c73b73eb7adb978f2e78c5 | link ]]


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102424/new/

https://reviews.llvm.org/D102424