[PATCH] D102383: [ELF] Add -Bno-symbolic

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 14 01:16:51 PDT 2021


jhenderson added a comment.

In D102383#2758982 <https://reviews.llvm.org/D102383#2758982>, @jhenderson wrote:

> You said that -Bsymbolic-functions is undertested, so I assume the behaviour of "last one wins" for -Bsymbolic-functions + -Bsymbolic will be covered by that work? If so, LGTM. If not, I think you should expand the bsymbolic.s input such that -Bsymbolic and -Bsymbolic-functions output looks different somehow.

Oh, I missed D102461 <https://reviews.llvm.org/D102461>, combined with a misreading of the test coverage. LGTM!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102383/new/

https://reviews.llvm.org/D102383



More information about the llvm-commits mailing list