[PATCH] D102269: [ARM] Expand predecessor search to multiple blocks when reverting WhileLoopStarts

Malhar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 14 01:10:39 PDT 2021


malharJ added inline comments.


================
Comment at: llvm/lib/Target/ARM/MVETPAndVPTOptimisationsPass.cpp:281
-    for (MachineInstr &MI : *PreHeader) {
-      if (MI.isCall()) {
-        // Create a t2DoLoopStart at the end of the preheader.
----------------
malharJ wrote:
> Uhm, just trying to understand the original logic ...
> 
> but why does a call (in the Preheader) result in reversion of t2WhileLoopStartLR to t2DoLoopStart ?
What I meant was wouldn't a call (in the preheader/predecessor) be placed before the t2WhileLoopStartLR (since it's a terminator) ... and hence it should not matter if LR get's overwritten by the call ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102269/new/

https://reviews.llvm.org/D102269



More information about the llvm-commits mailing list