[PATCH] D102437: [LV] NFCI: Move implementation of isScalarWithPredication to LoopVectorizationLegality

[Caroline via Phabricator via llvm-commits]

CarolineConcatto added a comment.

Hey Sander,
This patch is a fresh air to my eyes.
Thank you! 
I think you need to run git-clang-format and I have one more comment.



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:1520
   // Superset of instructions that return true for isScalarWithPredication.
   bool isPredicatedInst(Instruction *I, ElementCount VF) {
+    if (!Legal->blockNeedsPredication(I->getParent()) && !foldTailByMasking())
----------------
This ElementCount VF can go away because it is not being used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102437/new/

https://reviews.llvm.org/D102437