[PATCH] D101272: [llvm-objdump][XCOFF][AIX] Enable the -l (--line-numbers) option.

Thu May 13 20:00:13 PDT 2021

Esme added a comment.

In D101272#2747236 <https://reviews.llvm.org/D101272#2747236>, @jhenderson wrote:

> In D101272#2747181 <https://reviews.llvm.org/D101272#2747181>, @Esme wrote:
>
>> In D101272#2728191 <https://reviews.llvm.org/D101272#2728191>, @jhenderson wrote:
>>
>>> There seem to be quite a few new code paths added in this patch, and I'm not convinced they are all tested? Please add the necessary testing.
>>
>> It appears that the --line-numbers option can't cover these paths. 
>> I would be very grateful if you have any suggestions for adding tests, or find any examples I can follow. Thanks!
>
> For the parts that aren't required and can't be exercised at all, it seems like you should be able to just leave them out? For those parts that are required, you could add gtest unit testing to cover them. See llvm/unittest/Object for some examples.

The return values of these two hooks do not affect the result of line number. I removed these paths in the patch and will post another patch to implement them.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101272/new/

https://reviews.llvm.org/D101272